quoted ssh command should work on windows and linux #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgardner4012
force-pushed
the
broken_custom_facts_on_windows
branch
from
d8a8ace
to
2723a30
Compare
silug
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #174
Tested on windows 11 box:
`C:\Users\vagrant\Custom_facts>facter --custom-dir ./ ssh_host_keys
[
"PROGRAMDATA\ssh/ssh_host_rsa_key",
"PROGRAMDATA\ssh/ssh_host_ecdsa_key",
"PROGRAMDATA\ssh/ssh_host_ed25519_key"
]
C:\Users\vagrant\Custom_facts>facter --custom-dir ./ openssh_version
8.0
`
Tested on rocky8:
`[root@rocky8 custom_facts]# facter --custom-dir ./ openssh_version
8.0
[root@rocky8 custom_facts]# facter --custom-dir ./ ssh_host_keys
[
"/etc/ssh/ssh_host_rsa_key"
]`