-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add isHashed
flag to createSrpSession to allow users to defer password hashing to signSrpSession
#29
Merged
simonmcallister0210
merged 20 commits into
main
from
26-incorrect-password-hash-when-using-account-alias-or-regular-username
Mar 26, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d hashing to signSrpSession
…sing flaking tests
simonmcallister0210
added a commit
that referenced
this pull request
Mar 26, 2024
…in `createSrpSession` (#29) * add isHashed flag to createSrpSession to allow users to defer password hashing to signSrpSession * fix integration test * update tests * add node v21 to test since it's in active use * fix incorrectly referenced env var * ban 0 for short public key test cases to stop AbortOnZeroSrpError causing flaking tests * update integration tests * update test workflow with new github action secrets * update github actions node version * update github actions node version * drop support for node v16 * only run integration tests after unit tests * drop tests for node v21 for now * only run integration tests if unit tests pass * update API docs in README. add section about password hashing * rm node v21 for release workflow * rm comment * update README examples * update CONTRIBUTING * typo --------- Co-authored-by: Simon McAllister <[email protected]> Co-authored-by: Simon McAllister <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Email and Phone logins don't work because hashing requires the user ID. See this issue for details. To fix this we can allow users to defer hashing until the signing operation. At this point we'll have access to user ID, which will allow users to login with their Email and Phone number
Changes
isHashed
parameter tocreateSrpSession
signSrpSession
ifisHashed=fasle
Testing
With password hashing - users can only authenticate with Username (aka. user ID)
Without password hashing - users can authenticate with Username (aka. user ID), and email