Ensure pools are consistent when we store objects

This was broken by a recent commit as slotid is populated when a mock object is actually stored in the session, but the object was not added to the pool, leading the code that frees object to complain the pool was in an inconsistent state because the object could not be found there. Signed-off-by: Simo Sorce <[email protected]>
simo5 · Oct 8, 2024 · d331101 · d331101
1 parent cb9e4d5
commit d331101
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/objects.c b/src/objects.c
@@ -3315,6 +3315,12 @@ static CK_RV p11prov_obj_store_public_key(P11PROV_OBJ *key)
         rv = CKR_GENERAL_ERROR;
     }
 
+    if (rv == CKR_OK) {
+        /* this is a real object now, add it to the pool, but do not
+         * fail if the operation goes haywire for some reason */
+        (void)obj_add_to_pool(key);
+    }
+
     return rv;
 }