Using old pointer after reallocating new buffer

Below issue is reported while running TLS1.3:- p11prov_DeriveKey:Host out of memory Issue occurs because we are trying to use deallocated memory pointer after reallocating new memory due to which key->attrs get corrupted and finally cause issue in importing correct peer key. Signed-off-by: Kshitiz Varshney <[email protected]>
simo5 · Sep 3, 2024 · 21d7789 · 21d7789
1 parent 75cc2c3
commit 21d7789
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/objects.c b/src/objects.c
@@ -2930,8 +2930,8 @@ CK_RV p11prov_obj_set_ec_encoded_public_key(P11PROV_OBJ *key,
     }
 
     if (add_attrs > 0) {
-        void *ptr = OPENSSL_realloc(key->attrs, sizeof(CK_ATTRIBUTE) * (key->numattrs + add_attrs));
-        if (!ptr) {
+        key->attrs = OPENSSL_realloc(key->attrs, sizeof(CK_ATTRIBUTE) * (key->numattrs + add_attrs));
+        if (!key->attrs) {
             P11PROV_raise(key->ctx, CKR_HOST_MEMORY,
                           "Failed to store key public key");
             return CKR_HOST_MEMORY;