Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x86/sse: Fix type convert error for LSX. #1215

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Conversation

yinshiyou
Copy link
Contributor

When compile webkitgtk-2.45.92, failed with following error:
webkitgtk-2.45.92/Source/WTF/wtf/simde/arm/neon.h:92893:38: 错误:cannot convert ‘_m128’ to ‘v2i64’ in assignment
92893 | r
.lsx_i64 = _lsx_vfrintrm_s(a.lsx_f32);
| ~~~~~~~~~~~~~~~~^~~~~~~~~~~~
| |
| __m128

@mr-c
Copy link
Collaborator

mr-c commented Sep 10, 2024

Thank you for the report and the fix, @yinshiyou

What is your compiler and its version?

@yinshiyou
Copy link
Contributor Author

yinshiyou commented Sep 11, 2024

I use upstream gcc14 on loongson platform.
The previous code was developed base on the internal old version gcc of loongson which has defined inappropriate return types for some LSX builtin API. The new version has fiexed it.
Upstream gcc14 has merged LoongArch support, and it's return types of those LSX builtin API are correct .

@mr-c
Copy link
Collaborator

mr-c commented Sep 11, 2024

I use upstream gcc14 on loongson platform. The previous code was developed base on the internal old version gcc of loongson which has defined inappropriate return types for some LSX builtin API. The new version has fiexed it. Upstream gcc14 has merged LoongArch support, and it's return types of those LSX builtin API are correct .

Thanks, can you give me the output of --version for your gcc14?

Can you suggest updates to

linux-gcc-loongarch64:
so we can use this newer compiler to confirm your fixes?

@yinshiyou
Copy link
Contributor Author

I use upstream gcc14 on loongson platform. The previous code was developed base on the internal old version gcc of loongson which has defined inappropriate return types for some LSX builtin API. The new version has fiexed it. Upstream gcc14 has merged LoongArch support, and it's return types of those LSX builtin API are correct .

Thanks, can you give me the output of --version for your gcc14?

gcc (GCC) 14.1.0
Copyright © 2024 Free Software Foundation, Inc.

Can you suggest updates to

linux-gcc-loongarch64:

so we can use this newer compiler to confirm your fixes?

Ok, I will try to update CI environment asap.

@mr-c
Copy link
Collaborator

mr-c commented Sep 11, 2024

@yinshiyou Thanks!

I'm testing some CI updates over at #1217

@yinshiyou
Copy link
Contributor Author

@yinshiyou Thanks!

I'm testing some CI updates over at #1217

OK, Let's do it in #1217

Copy link
Collaborator

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yinshiyou
Copy link
Contributor Author

Thank you for updating the CI for loongson.

@mr-c mr-c merged commit 59bf8de into simd-everywhere:master Sep 12, 2024
96 of 97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants