Skip to content

Commit

Permalink
- added correct min/max temps for water heaters
Browse files Browse the repository at this point in the history
  • Loading branch information
simbaja committed Sep 17, 2022
1 parent 992623b commit 15a8a1d
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
2 changes: 2 additions & 0 deletions custom_components/ge_home/devices/water_heater.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ def get_all_entities(self) -> List[Entity]:
GeErdSensor(self, ErdCode.WH_HEATER_TARGET_TEMPERATURE),
GeErdSensor(self, ErdCode.WH_HEATER_TEMPERATURE),
GeErdSensor(self, ErdCode.WH_HEATER_MODE_HOURS_REMAINING),
GeErdSensor(self, ErdCode.WH_HEATER_ELECTRIC_MODE_MAX_TIME),
GeErdSensor(self, ErdCode.WH_HEATER_VACATION_MODE_MAX_TIME),
GeWaterHeater(self)
]

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,16 +61,14 @@ def target_temperature(self) -> Optional[int]:
@property
def min_temp(self) -> int:
"""Return the minimum temperature."""
#min_temp, _ = self.appliance.get_erd_value(ErdCode.OVEN_MODE_MIN_MAX_TEMP)
#return min_temp
return 100
min_temp, _ = self.appliance.get_erd_value(ErdCode.WH_HEATER_MIN_MAX_TEMPERATURE)
return min_temp

@property
def max_temp(self) -> int:
"""Return the maximum temperature."""
#_, max_temp = self.appliance.get_erd_value(ErdCode.OVEN_MODE_MIN_MAX_TEMP)
#return max_temp
return 200
_, max_temp = self.appliance.get_erd_value(ErdCode.WH_HEATER_MIN_MAX_TEMPERATURE)
return max_temp

async def async_set_operation_mode(self, operation_mode: str):
"""Set the operation mode."""
Expand Down
2 changes: 1 addition & 1 deletion custom_components/ge_home/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"name": "GE Home (SmartHQ)",
"config_flow": true,
"documentation": "https://github.com/simbaja/ha_gehome",
"requirements": ["gehomesdk==0.5.6","magicattr==0.1.5","slixmpp==1.7.1"],
"requirements": ["gehomesdk==0.5.7","magicattr==0.1.5","slixmpp==1.7.1"],
"codeowners": ["@simbaja"],
"version": "0.6.5"
}

0 comments on commit 15a8a1d

Please sign in to comment.