Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 2 nonexistent fonts from testdata/fontrules.json #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove 2 nonexistent fonts from testdata/fontrules.json #9

wants to merge 1 commit into from

Conversation

imnasnainaec
Copy link
Contributor

Resolves #7

@imnasnainaec
Copy link
Contributor Author

I've run scripts/fontrules on the sldr subfolder of https://github.com/silnrsi/sldr/archive/refs/heads/master.zip to confirm that neither "Leke" nor "Shuishu" fonts are in the result.

@imnasnainaec imnasnainaec mentioned this pull request Aug 14, 2023
Merged
@DavidLRowe
Copy link
Contributor

@mhosken On one hand it doesn't affect any of the current tests to have this non-existent font in the test data, so this change isn't absolutely needed. OTOH it might be neater to remove the non-existent font to avoid future questions about it.
Opinions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove non-existent Noto Sans Leke & Noto Sans Shuishu
2 participants
@imnasnainaec @DavidLRowe