Merge pull request #1304 from sillsdev/BL-12373-BulletProofScriptAndV…

…ariantDlg Prevent editing combobox controls for Script and Variant dialog
sillsdev · Nov 7, 2023 · ff6e273 · ff6e273
2 parents 683679a + 0af00d3
commit ff6e273
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -42,6 +42,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Fixed
 
+- [SIL.Windows.Forms.WritingSystem.WSIdentifiers] Changed ComboBox controls in WSIdentifierView and ScriptRegionVariantView to DropDownList style to prevent accidental editing that shouldn't happen
 - [SIL.Windows.Forms.ClearShare] Make Metadata.Write (and a few other methods) more robust
 - [SIL.Core.Desktop] Make FileUtils.ReplaceFileWithUserInteractionIfNeeded robust
 - [SIL.Core] Make RobustFile.ReplaceByCopyDelete truly robust

diff --git a/SIL.Windows.Forms.WritingSystems/WSIdentifiers/ScriptRegionVariantView.Designer.cs b/SIL.Windows.Forms.WritingSystems/WSIdentifiers/ScriptRegionVariantView.Designer.cs
diff --git a/SIL.Windows.Forms.WritingSystems/WSIdentifiers/WSIdentifierView.cs b/SIL.Windows.Forms.WritingSystems/WSIdentifiers/WSIdentifierView.cs
@@ -58,6 +58,7 @@ public void BindToModel(WritingSystemSetupModel model)
 			_specialTypeComboBox.DisplayMember = "ChoiceName";
 			_specialTypeComboBox.SelectedIndex = 0;
 			UpdateFromModel();
+			_specialTypeComboBox.DropDownStyle = ComboBoxStyle.DropDownList;
 			_specialTypeComboBox.SelectedIndexChanged += specialTypeComboBox_SelectedIndexChanged;
 			if (_model.IsSpecialComboLocked)
 			{