Break out convertConfig into modular functions for SAB / DAB #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrapped almost all parsing functions Wrapped parseBookCollections, removed some usages of global variable 'data' (to be continued) Continued converting functions. Stopped at parsedLayouts Completed calls for parsing functions Added conditional logic for data type Finished breaking out functions, applied feedback, Added conditional logic for calls Fixed typing issues with convertBooks Fixed wrapping issue for layouts and book collections Resolved data type issues in convertConfig Resolved issues in convertBooks, Plans, Contents
EthanFennell
force-pushed
the
feature/parse-specific-config/676
branch
from
691fe8d to
7dbfc23
Compare
aidanpscott
pushed a commit
that referenced
this pull request
Nov 22, 2024
* Initial setup and comments made for collaboration Wrapped almost all parsing functions Wrapped parseBookCollections, removed some usages of global variable 'data' (to be continued) Continued converting functions. Stopped at parsedLayouts Completed calls for parsing functions Added conditional logic for data type Finished breaking out functions, applied feedback, Added conditional logic for calls Fixed typing issues with convertBooks Fixed wrapping issue for layouts and book collections Resolved data type issues in convertConfig Resolved issues in convertBooks, Plans, Contents * Resolved issues with json config file * Fixed various issues in config * Fixed plan parsing when plans is empty * Fixed lint failure
aidanpscott
pushed a commit
that referenced
this pull request
Dec 3, 2024
* Initial setup and comments made for collaboration Wrapped almost all parsing functions Wrapped parseBookCollections, removed some usages of global variable 'data' (to be continued) Continued converting functions. Stopped at parsedLayouts Completed calls for parsing functions Added conditional logic for data type Finished breaking out functions, applied feedback, Added conditional logic for calls Fixed typing issues with convertBooks Fixed wrapping issue for layouts and book collections Resolved data type issues in convertConfig Resolved issues in convertBooks, Plans, Contents * Resolved issues with json config file * Fixed various issues in config * Fixed plan parsing when plans is empty * Fixed lint failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.