Videos other than Jesus Film videos crash convertConfig (#428)

Fixes issue #427 This does not make all the other video types play. It just avoids the crash by providing default values for nonexistent fields
sillsdev · Dec 5, 2023 · 8af7975 · 8af7975
1 parent 7071691
commit 8af7975
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/scripts/convertConfig.ts b/scripts/convertConfig.ts
@@ -685,13 +685,22 @@ function convertConfig(dataDir: string, verbose: number) {
                               .getNamedItem('ref')!
                               .value.split('|')[0]
                       };
+            const tagWidth = tag.attributes.getNamedItem('width')
+                ? parseInt(tag.attributes.getNamedItem('width')!.value)
+                : 0;
+            const tagHeight = tag.attributes.getNamedItem('height')
+                ? parseInt(tag.attributes.getNamedItem('width')!.value)
+                : 0;
+            const onlineUrlHTML = tag.getElementsByTagName('online-url')[0]
+                ? tag.getElementsByTagName('online-url')[0]?.innerHTML
+                : '';
             data.videos.push({
                 id: tag.attributes.getNamedItem('id')!.value,
-                width: parseInt(tag.attributes.getNamedItem('width')!.value),
-                height: parseInt(tag.attributes.getNamedItem('height')!.value),
+                width: tagWidth,
+                height: tagHeight,
                 title: tag.getElementsByTagName('title')[0]?.innerHTML,
                 thumbnail: tag.getElementsByTagName('thumbnail')[0]?.innerHTML,
-                onlineUrl: decodeFromXml(tag.getElementsByTagName('online-url')[0]?.innerHTML),
+                onlineUrl: decodeFromXml(onlineUrlHTML),
                 placement
             });
         }