Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create eslint.yml #3413

Closed
wants to merge 1 commit into from
Closed

Create eslint.yml #3413

wants to merge 1 commit into from

Conversation

bobbeck55
Copy link
Collaborator

@bobbeck55 bobbeck55 commented Oct 31, 2024

new workflow - runs eslint on code


This change is Reviewable

new workflow - runs eslint on code
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.67%. Comparing base (e349e02) to head (5f0d8d0).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3413      +/-   ##
==========================================
- Coverage   74.63%   66.67%   -7.96%     
==========================================
  Files         285      234      -51     
  Lines       10978     5800    -5178     
  Branches     1335      703     -632     
==========================================
- Hits         8193     3867    -4326     
+ Misses       2401     1709     -692     
+ Partials      384      224     -160     
Flag Coverage Δ
backend ?
frontend 66.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec
Copy link
Collaborator

Hi, @bobbeck55. We do already have linting in our frontend workflow (https://github.com/sillsdev/TheCombine/blob/master/.github/workflows/frontend.yml#L39)

      - run: npm run lint

which runs ESLint (https://github.com/sillsdev/TheCombine/blob/master/package.json#L24)

    "lint": "           eslint --max-warnings=0 --ext js,ts,tsx,jsx src",

@imnasnainaec imnasnainaec deleted the bobbeck55-patch-1 branch December 11, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants