Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer] Update docs, comments, pw #3391

Merged
merged 9 commits into from
Oct 10, 2024
Merged

[installer] Update docs, comments, pw #3391

merged 9 commits into from
Oct 10, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Oct 7, 2024

This change is Reviewable

@imnasnainaec imnasnainaec added documentation Improvements or additions to documentation deployment labels Oct 7, 2024
@imnasnainaec imnasnainaec self-assigned this Oct 7, 2024
@imnasnainaec imnasnainaec changed the title Update installer docs, comments, pw [installer] Update docs, comments, pw Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.70%. Comparing base (0dc83d0) to head (2c9cfbd).
Report is 16 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3391   +/-   ##
=======================================
  Coverage   74.70%   74.70%           
=======================================
  Files         280      280           
  Lines       10856    10856           
  Branches     1317     1317           
=======================================
  Hits         8110     8110           
  Misses       2374     2374           
  Partials      372      372           
Flag Coverage Δ
backend 83.92% <ø> (ø)
frontend 66.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 7 files at r1, 11 of 11 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 58b6cd5 into master Oct 10, 2024
18 checks passed
@imnasnainaec imnasnainaec deleted the installer branch October 10, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants