Clean up build/deploy scripts and docs #3390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imnasnainaec
added
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3390 +/- ##
=======================================
Coverage 74.71% 74.71%
=======================================
Files 280 280
Lines 10838 10838
Branches 1314 1314
=======================================
Hits 8098 8098
Misses 2370 2370
Partials 370 370
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
imnasnainaec
force-pushed
the
nuc-install
branch
from
7f0b83f to
755b4bc
Compare
imnasnainaec
changed the title
jasonleenaylor
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Reviewed 3 of 4 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build.py's deprecated--nerdctloptionbuild.pydebug loggingdeploy/ansible/, use.yml(instead of a mix of.yamland.yml)docs/deploy/README.md, especially wrt NUC deploymentThis change is