Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Guide] Fix displaced note #3325

Merged
merged 2 commits into from
Aug 26, 2024
Merged

[User Guide] Fix displaced note #3325

merged 2 commits into from
Aug 26, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Aug 23, 2024

The note text wasn't indented, resulting in an empty note followed by a paragraph with the intended note content.

Before:
Screenshot 2024-08-23 145259

After:
Screenshot 2024-08-23 145326


This change is Reviewable

@imnasnainaec imnasnainaec added documentation Improvements or additions to documentation Size: S Small sized issue labels Aug 23, 2024
@imnasnainaec imnasnainaec self-assigned this Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.82%. Comparing base (46b4c7f) to head (839bb44).
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3325      +/-   ##
==========================================
+ Coverage   74.77%   74.82%   +0.04%     
==========================================
  Files         278      278              
  Lines       10708    10708              
  Branches     1291     1291              
==========================================
+ Hits         8007     8012       +5     
+ Misses       2337     2333       -4     
+ Partials      364      363       -1     
Flag Coverage Δ
backend 83.99% <ø> (+0.10%) ⬆️
frontend 66.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 8802659 into master Aug 26, 2024
19 checks passed
@imnasnainaec imnasnainaec deleted the crowdin-again branch August 26, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Size: S Small sized issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants