Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Recorder] Toast error if record fails #3322

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Aug 23, 2024

Fixes #3319


This change is Reviewable

@imnasnainaec imnasnainaec added bug Something isn't working frontend audio labels Aug 23, 2024
@imnasnainaec imnasnainaec self-assigned this Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Project coverage is 74.77%. Comparing base (8802659) to head (41b2c76).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
src/components/Pronunciations/Recorder.ts 0.00% 6 Missing ⚠️
src/components/Pronunciations/AudioRecorder.tsx 0.00% 5 Missing ⚠️
src/components/Pronunciations/utilities.ts 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3322      +/-   ##
==========================================
- Coverage   74.77%   74.77%   -0.01%     
==========================================
  Files         278      278              
  Lines       10708    10715       +7     
  Branches     1291     1294       +3     
==========================================
+ Hits         8007     8012       +5     
- Misses       2337     2340       +3     
+ Partials      364      363       -1     
Flag Coverage Δ
backend 83.99% <ø> (+0.10%) ⬆️
frontend 66.71% <14.28%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit a683036 into master Aug 26, 2024
19 checks passed
@imnasnainaec imnasnainaec deleted the recorder-firefox-error branch August 26, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audio bug Something isn't working frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On Firefox, when no mic permission, recording silently fails
2 participants