Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReviewEntries] Persist column order/visibility state in project #3309

Merged
merged 13 commits into from
Sep 27, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Aug 15, 2024

Resolves #3305

This change is Reviewable

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 56.25000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 74.59%. Comparing base (f08ded3) to head (2a12153).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
src/components/Project/ProjectReducer.ts 9.09% 10 Missing ⚠️
src/components/Project/ProjectActions.ts 50.00% 2 Missing ⚠️
...c/goals/ReviewEntries/ReviewEntriesTable/index.tsx 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3309      +/-   ##
==========================================
- Coverage   74.69%   74.59%   -0.11%     
==========================================
  Files         280      280              
  Lines       10745    10773      +28     
  Branches     1297     1299       +2     
==========================================
+ Hits         8026     8036      +10     
- Misses       2353     2370      +17     
- Partials      366      367       +1     
Flag Coverage Δ
backend 83.81% <ø> (-0.09%) ⬇️
frontend 66.61% <56.25%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec marked this pull request as ready for review August 15, 2024 21:18
@imnasnainaec imnasnainaec changed the title [ReviewEntries] Persist column order/visibility state [ReviewEntries] Persist column order/visibility state in project Aug 15, 2024
@jasonleenaylor
Copy link
Contributor

src/components/Project/ProjectReducer.ts line 13 at r2 (raw file):

    setColumnOrderAction: (state, action) => {
      const columns = state.reviewEntriesColumns;
      if (typeof action.payload === "function") {

I must have missed it, how could this be something that isn't a function?

@jasonleenaylor
Copy link
Contributor

src/components/Project/ProjectReducer.ts line 13 at r2 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

I must have missed it, how could this be something that isn't a function?

Oh, its because of definition and part-of-speech isn't it. A comment would be good.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 6bbfc5b into master Sep 27, 2024
18 checks passed
@imnasnainaec imnasnainaec deleted the review-entries-columns branch September 27, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ReviewEntries] Remember which columns the user hid
2 participants