-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C is for Cookie, that's good enough for me #3301
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3301 +/- ##
==========================================
+ Coverage 74.68% 74.72% +0.03%
==========================================
Files 278 280 +2
Lines 10715 10734 +19
Branches 1294 1296 +2
==========================================
+ Hits 8003 8021 +18
- Misses 2347 2349 +2
+ Partials 365 364 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Maybe this comment should say 'for running' instead of 'to run' just for clarity. I was confused until I looked at how this got used elsewhere. Code quote: Suspense> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 15 of 15 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Resolves #3007
At bottom of window with various window widths:
This change is