Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C is for Cookie, that's good enough for me #3301

Merged
merged 23 commits into from
Aug 26, 2024
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Aug 8, 2024

Resolves #3007

At bottom of window with various window widths:
Screenshot 2024-08-19 at 09 50 25
Screenshot 2024-08-19 at 09 49 52
Screenshot 2024-08-19 at 09 49 19


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Aug 8, 2024
@imnasnainaec imnasnainaec added the maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. label Aug 8, 2024
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 10 lines in your changes missing coverage. Please review.

Project coverage is 74.72%. Comparing base (a683036) to head (4bdf330).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
src/cookies/useCookieConsent.tsx 58.33% 5 Missing ⚠️
src/components/Login/Redux/LoginActions.ts 25.00% 2 Missing and 1 partial ⚠️
src/components/UserSettings/UserSettings.tsx 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3301      +/-   ##
==========================================
+ Coverage   74.68%   74.72%   +0.03%     
==========================================
  Files         278      280       +2     
  Lines       10715    10734      +19     
  Branches     1294     1296       +2     
==========================================
+ Hits         8003     8021      +18     
- Misses       2347     2349       +2     
+ Partials      365      364       -1     
Flag Coverage Δ
backend 83.99% <ø> (+0.18%) ⬆️
frontend 66.64% <54.54%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec marked this pull request as ready for review August 12, 2024 21:02
@jasonleenaylor
Copy link
Contributor

src/cookies/CookieConsent.tsx line 5 at r2 (raw file):

import useCookieConsent from "cookies/useCookieConsent";

/** Empty component to run useCookieConsent within a <Suspense>,

Maybe this comment should say 'for running' instead of 'to run' just for clarity. I was confused until I looked at how this got used elsewhere.

Code quote:

Suspense>

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 15 of 15 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) August 26, 2024 18:32
@imnasnainaec imnasnainaec merged commit bfc9230 into master Aug 26, 2024
19 checks passed
@imnasnainaec imnasnainaec deleted the cookie-monster branch August 26, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring our cookies up to industry standards
2 participants