-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ProjectSettings] Refactor with Accordian component #3233
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3233 +/- ##
==========================================
+ Coverage 74.72% 74.77% +0.05%
==========================================
Files 278 278
Lines 10710 10708 -2
Branches 1291 1291
==========================================
+ Hits 8003 8007 +4
+ Misses 2342 2337 -5
+ Partials 365 364 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 5 files at r1, 4 of 4 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Resolves #3113
Before
Users tab default
After
Users tab default, all exanded
Users tab one collapsed
Schedule tab default, wider
Semantic Domains tab default, Custom Semantic Domains setting contains collapsed-by-default accordions
Basic Settings tab, all collapsed
This change is