Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ProjectSettings] Refactor with Accordian component #3233

Merged
merged 10 commits into from
Aug 23, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jul 5, 2024

Resolves #3113

Before

Users tab default
Screenshot 2024-08-19 102632

After

Users tab default, all exanded
Screenshot 2024-08-22 121017

Users tab one collapsed
Screenshot 2024-08-22 121033

Schedule tab default, wider
Screenshot 2024-08-22 121053

Semantic Domains tab default, Custom Semantic Domains setting contains collapsed-by-default accordions
Screenshot 2024-08-22 121113

Basic Settings tab, all collapsed
Screenshot 2024-08-22 121134


This change is Reviewable

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.77%. Comparing base (7ef8502) to head (d16f263).
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3233      +/-   ##
==========================================
+ Coverage   74.72%   74.77%   +0.05%     
==========================================
  Files         278      278              
  Lines       10710    10708       -2     
  Branches     1291     1291              
==========================================
+ Hits         8003     8007       +4     
+ Misses       2342     2337       -5     
+ Partials      365      364       -1     
Flag Coverage Δ
backend 83.89% <ø> (+0.08%) ⬆️
frontend 66.79% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec marked this pull request as ready for review July 8, 2024 17:40
@imnasnainaec imnasnainaec marked this pull request as draft August 22, 2024 14:03
@imnasnainaec imnasnainaec marked this pull request as ready for review August 22, 2024 14:33
@imnasnainaec imnasnainaec marked this pull request as draft August 22, 2024 15:34
@imnasnainaec imnasnainaec marked this pull request as ready for review August 22, 2024 16:18
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 5 files at r1, 4 of 4 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 2fff26d into master Aug 23, 2024
19 checks passed
@imnasnainaec imnasnainaec deleted the proj-settings-accordian branch August 23, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Project Settings] Add visual indication of collapsed sections
2 participants