Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TreeView] Improve ENTER key behavior #3221

Merged
merged 4 commits into from
Jul 10, 2024
Merged

[TreeView] Improve ENTER key behavior #3221

merged 4 commits into from
Jul 10, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jul 2, 2024

Fixes #3215

  • Adds functionality for Enter key to select the current domain when navigating the tree with arrows
  • Removes ability to tab-select any of the domain tiles other than the current domain

This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.77%. Comparing base (8b152c2) to head (d0f2610).
Report is 42 commits behind head on master.

Files with missing lines Patch % Lines
src/components/TreeView/TreeNavigator.tsx 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3221      +/-   ##
==========================================
- Coverage   74.80%   74.77%   -0.04%     
==========================================
  Files         277      277              
  Lines       10635    10637       +2     
  Branches     1278     1278              
==========================================
- Hits         7956     7954       -2     
- Misses       2315     2318       +3     
- Partials      364      365       +1     
Flag Coverage Δ
backend 83.92% <ø> (-0.03%) ⬇️
frontend 66.69% <75.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec requested a review from andracc July 10, 2024 18:55
Copy link
Collaborator

@andracc andracc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit b06fac6 into master Jul 10, 2024
19 checks passed
@imnasnainaec imnasnainaec deleted the tree-view-enter branch July 10, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TreeView] Bad ENTER behavior when navigating the tree
2 participants