Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NewEntry] Prevent crash when duplicate vernacular is cleared #3072

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Apr 23, 2024

Fixes #3071


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Apr 23, 2024
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 74.95%. Comparing base (bc9f532) to head (78a7923).

Files Patch % Lines
...s/DataEntry/DataEntryTable/NewEntry/VernDialog.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3072      +/-   ##
==========================================
- Coverage   74.97%   74.95%   -0.03%     
==========================================
  Files         269      269              
  Lines       10359    10361       +2     
  Branches     1225     1226       +1     
==========================================
- Hits         7767     7766       -1     
- Misses       2235     2236       +1     
- Partials      357      359       +2     
Flag Coverage Δ
backend 84.03% <ø> (-0.03%) ⬇️
frontend 66.59% <50.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work figuring out how to test this.
:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 87bcb10 into master Apr 23, 2024
18 checks passed
@imnasnainaec imnasnainaec deleted the vern-dialog-empty branch April 23, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataEntryTable > NewEntry] Removing the whole vernacular, if a duplicate, crashes the page
2 participants