Increase "react", "api" import specificity

[imnasnainaec]

Also, avoids usage of import React and React. for potential upcoming TS transpiler change.

This change is 

[codecov]

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 74.97%. Comparing base (613bd07) to head (943f4ac).

Files	Patch %	Lines
src/components/AppBar/UserMenu.tsx	0.00%	1 Missing ⚠️
...Table/EntryCellComponents/GlossWithSuggestions.tsx	0.00%	1 Missing ⚠️
...yTable/EntryCellComponents/VernWithSuggestions.tsx	0.00%	1 Missing ⚠️
src/components/Dialogs/DeleteEditTextDialog.tsx	0.00%	1 Missing ⚠️
src/components/Dialogs/EditTextDialog.tsx	0.00%	1 Missing ⚠️
src/components/Dialogs/SubmitTextDialog.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2973      +/-   ##
==========================================
- Coverage   74.98%   74.97%   -0.01%     
==========================================
  Files         269      269              
  Lines       10358    10358              
  Branches     1225     1225              
==========================================
- Hits         7767     7766       -1     
  Misses       2234     2234              
- Partials      357      358       +1     

Flag	Coverage Δ
backend	84.03% <ø> (-0.03%)	⬇️
frontend	66.62% <53.84%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jmgrady]

Reviewed 15 of 31 files at r1, all commit messages.
Reviewable status: 15 of 31 files reviewed, all discussions resolved (waiting on @imnasnainaec)

[jmgrady]

Reviewed 16 of 31 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @imnasnainaec)

---

src/components/TreeView/TreeNavigator.tsx line 1 at r1 (raw file):

import { Fragment, type ReactElement, useEffect } from "react";

Here the type import is not at the beginning of the list but in other updates, the types are all moved to the front, e.g. in src/components/TreeView/tests/TreeSearch.test.tsx:

import TreeSearch, {
  type TreeSearchProps,
  insertDecimalPoints,
  testId,
  useTreeSearch,
} from "components/TreeView/TreeSearch";
```.
Should `type ReactElement` be moved to the beginning?

Code quote:

import { Fragment, type ReactElement, useEffect } from "react";

---

src/components/TreeView/tests/TreeSearch.test.tsx line 13 at r1 (raw file):
This seems to contradict the recommendation:

• Generally import the specific things needed (e.g., not React when { type ReactElement } will do)

That recommendation suggests that default exports should be avoided and only export specific types/objects.

If that is a direction we want to take, I am in favor of it being a separate PR.

Code quote:

import TreeSearch, {
  type TreeSearchProps,
  insertDecimalPoints,
  testId,
  useTreeSearch,
} from "components/TreeView/TreeSearch";

[imnasnainaec]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

---

src/components/TreeView/TreeNavigator.tsx line 1 at r1 (raw file):

Previously, jmgrady (Jim Grady) wrote…

Here the type import is not at the beginning of the list but in other updates, the types are all moved to the front, e.g. in src/components/TreeView/tests/TreeSearch.test.tsx:

import TreeSearch, {
  type TreeSearchProps,
  insertDecimalPoints,
  testId,
  useTreeSearch,
} from "components/TreeView/TreeSearch";
```.
Should `type ReactElement` be moved to the beginning?

I hadn't intended to move type imports all to the front, but was maintaining the alphabetic sort (and with ESLint defaults, all capital letters sort before lowercase). Would it be easier to have the type imports clustered if they're to be type-prefixed?

---

src/components/TreeView/tests/TreeSearch.test.tsx line 13 at r1 (raw file):

Previously, jmgrady (Jim Grady) wrote…

This seems to contradict the recommendation:

• Generally import the specific things needed (e.g., not React when { type ReactElement } will do)

That recommendation suggests that default exports should be avoided and only export specific types/objects.

If that is a direction we want to take, I am in favor of it being a separate PR.

My intent is not to generally move away from default exports, but from using import * as ____ from if just a few things are needed. The * as is not needed with React because its default export is already a cumulative object. Any thoughts on better wording for the style guide?