Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MergeDups] Track deleted senses #2953

Merged
merged 26 commits into from
Mar 26, 2024
Merged

[MergeDups] Track deleted senses #2953

merged 26 commits into from
Mar 26, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Feb 16, 2024

Follows #2907
Precedes #2893


This change is Reviewable

@imnasnainaec imnasnainaec added frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. goal: MergeDup Size: S Small sized issue labels Feb 16, 2024
@imnasnainaec imnasnainaec self-assigned this Feb 16, 2024
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.76%. Comparing base (3312b57) to head (5a808ba).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2953   +/-   ##
=======================================
  Coverage   72.75%   72.76%           
=======================================
  Files         264      264           
  Lines       10201    10202    +1     
  Branches     1196     1196           
=======================================
+ Hits         7422     7423    +1     
  Misses       2429     2429           
  Partials      350      350           
Flag Coverage Δ
backend 82.78% <ø> (ø)
frontend 63.40% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec marked this pull request as ready for review February 23, 2024 19:22
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 87e1ac9 into master Mar 26, 2024
17 checks passed
@imnasnainaec imnasnainaec deleted the merge-deleted-senses branch March 26, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend goal: MergeDup maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. Size: S Small sized issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants