Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update current user handling of getAllActiveProjects #2951

Merged
merged 6 commits into from
Apr 1, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Feb 15, 2024

Inspired by #2949 (but doesn't resolve it because that's a backend issue).


This change is Reviewable

@imnasnainaec imnasnainaec added bug Something isn't working frontend project labels Feb 15, 2024
@imnasnainaec imnasnainaec self-assigned this Feb 15, 2024
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.47%. Comparing base (65f3ba5) to head (d29890f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2951      +/-   ##
==========================================
- Coverage   73.47%   73.47%   -0.01%     
==========================================
  Files         265      265              
  Lines       10304    10298       -6     
  Branches     1214     1212       -2     
==========================================
- Hits         7571     7566       -5     
  Misses       2378     2378              
+ Partials      355      354       -1     
Flag Coverage Δ
backend 82.92% <ø> (ø)
frontend 64.69% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec added maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. and removed bug Something isn't working labels Feb 16, 2024
@imnasnainaec imnasnainaec added the Size: S Small sized issue label Feb 16, 2024
@imnasnainaec imnasnainaec marked this pull request as ready for review February 16, 2024 15:31
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 6 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) April 1, 2024 14:06
Copy link
Collaborator Author

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 93750d6 into master Apr 1, 2024
17 checks passed
@imnasnainaec imnasnainaec deleted the user-projects branch April 1, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. project Size: S Small sized issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants