-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Consent Export] Include file-type extensions; Convert webm to wav #2900
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2900 +/- ##
==========================================
- Coverage 72.83% 72.70% -0.14%
==========================================
Files 266 266
Lines 10279 10303 +24
Branches 1212 1216 +4
==========================================
+ Hits 7487 7491 +4
- Misses 2444 2460 +16
- Partials 348 352 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r2, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)
Backend/Controllers/SpeakerController.cs
line 247 at r2 (raw file):
{ speaker.Consent = ConsentType.Audio; extension = ".webm";
So, what if someone uploads a .wav file, or an .ogg file?
We currently only support image upload. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Resolves #2897
Acceptance test:
This change is