-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up keys; Fix up GoalTimeline tests #2721
Conversation
Codecov ReportAttention:
... and 44 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 14 of 19 files at r1, 4 of 4 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jmgrady)
src/goals/ReviewEntries/ReviewEntriesComponent/CellComponents/NoteCell.tsx
line 13 at r3 (raw file):
<TextField variant="standard" key={`row-${props.rowData.id}-note`}
So we don't need this even if there is more than one note in the row?
Code quote:
key={`row-${props.rowData.id}-note`}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jmgrady)
src/goals/ReviewEntries/ReviewEntriesComponent/CellComponents/NoteCell.tsx
line 13 at r3 (raw file):
Previously, jasonleenaylor (Jason Naylor) wrote…
So we don't need this even if there is more than one note in the row?
The key (if necessary) will be assigned directly on the <NoteCell>
component wherever it is called. And in our case, each row only has one instance of each type of cell anyway (1 per column).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Resolves #2679
Removes unnecessary keys
Simplifies unnecessarily complicated keys
Replaces avoidable index-keys
Fixes GoalRedux/GoalTimeline testing
This change is