Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When removing from graylist, don't remove subsets #2670

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Oct 3, 2023

Resolves #2667


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Oct 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
Backend/Services/MergeService.cs 77.31% <100.00%> (ø)

... and 205 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) October 10, 2023 15:37
@imnasnainaec imnasnainaec merged commit b50bb01 into master Oct 10, 2023
16 checks passed
@imnasnainaec imnasnainaec deleted the black-gray-lists branch October 10, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blacklisting a set removes any subset from the graylist
3 participants