-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[InviteController] Clean up logic and add tests #2663
Conversation
Codecov ReportAttention:
... and 206 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @imnasnainaec and @jmgrady)
Backend/Controllers/InviteController.cs
line 150 at r2 (raw file):
public bool IsTokenValid { get; set; } [Required] public bool isUserValid { get; set; }
Is (C# style for properties)
Code quote:
is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @jasonleenaylor and @jmgrady)
Backend/Controllers/InviteController.cs
line 150 at r2 (raw file):
Previously, jasonleenaylor (Jason Naylor) wrote…
Is (C# style for properties)
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jmgrady)
Progress on #2647
This change is