split and merge steps

sillsdev · Jun 24, 2024 · e1d44be · e1d44be
1 parent 90e84d5
commit e1d44be
Showing 1 changed file with 26 additions and 29 deletions.
diff --git a/database/util/twoAnalysisSenseCleanup.js b/database/util/twoAnalysisSenseCleanup.js
@@ -12,11 +12,14 @@
     },
   },
   {
+    // Preserve the original document for later stages to use
     $addFields: {
-      // Preserve the original document for later stages to use
       originalDocument: "$$ROOT",
-
-      // Identify and extract 'to' and 'from' senses for merging based on gloss languages
+    },
+  },
+  {
+    // Identify and extract 'to' and 'from' senses for merging based on gloss languages
+    $addFields: {
       toSense: {
         $arrayElemAt: [
           {
@@ -55,14 +58,17 @@
           0,
         ],
       },
-
-      // Add fields to extract semantic domain GUIDs from both 'to' and 'from' senses
+    },
+  },
+  {
+    // Add fields to extract semantic domain GUIDs from both 'to' and 'from' senses
+    $addFields: {
       toSemDomGuids: "$toSense.SemanticDomains.guid",
       fromSemDomGuids: "$fromSense.SemanticDomains.guid",
     },
   },
   {
-    // Match documents where the semantic domains of 'to' sense are a subset of 'from' sense or 'to' sense has no semantic domains
+    // Match documents where the semantic domains of 'to' sense are a subset of 'from' sense or vice-versa
     $match: {
       $expr: {
         $or: [
@@ -77,41 +83,32 @@
     },
   },
   {
-    // Add fields to extract semantic domain GUIDs from both 'to' and 'from' senses
-    $addFields: {
-      semDoms: {
-        $cond: {
-          if: {
-            $gte: [{ $size: "$toSemDomGuids" }, { $size: "$fromSemDomGuids" }],
-          },
-          then: "$toSense.SemanticDomains",
-          else: "$fromSense.SemanticDomains",
-        },
-      },
-    },
-  },
-  {
-    // Merge the senses into one by combining glosses
+    // Update the original document's senses with a merge of the "to" and "from" senses
     $addFields: {
-      mergedSenses: {
+      "originalDocument.senses": {
         $mergeObjects: [
           "$toSense",
           {
             Glosses: {
               $concatArrays: ["$toSense.Glosses", "$fromSense.Glosses"],
             },
-            SemanticDomains: "$semDoms",
+            SemanticDomains: {
+              $cond: {
+                if: {
+                  $gte: [
+                    { $size: "$toSemDomGuids" },
+                    { $size: "$fromSemDomGuids" },
+                  ],
+                },
+                then: "$toSense.SemanticDomains",
+                else: "$fromSense.SemanticDomains",
+              },
+            },
           },
         ],
       },
     },
   },
-  {
-    // Update the original document's senses with the merged senses
-    $addFields: {
-      "originalDocument.senses": ["$mergedSenses"],
-    },
-  },
   {
     // Replace the root of the document with the updated original document
     $replaceRoot: {