Skip to content

Commit

Permalink
[Docker] Move away from legacy ENV assigment
Browse files Browse the repository at this point in the history
  • Loading branch information
imnasnainaec committed Oct 8, 2024
1 parent 7b93e42 commit 8ad50e7
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
12 changes: 6 additions & 6 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
# User guide build environment
FROM python:3.12.5-slim-bookworm AS user_guide_builder

ENV PYTHONDONTWRITEBYTECODE 1
ENV PYTHONUNBUFFERED 1
ENV PIP_NO_CACHE_DIR 1
ENV PYTHONDONTWRITEBYTECODE=1
ENV PYTHONUNBUFFERED=1
ENV PIP_NO_CACHE_DIR=1

WORKDIR /app

Expand Down Expand Up @@ -40,9 +40,9 @@ FROM nginx:1.27

WORKDIR /app

ENV HOST_DIR /usr/share/nginx
ENV USER_GUIDE_HOST_DIR ${HOST_DIR}/user_guide
ENV FRONTEND_HOST_DIR ${HOST_DIR}/html
ENV HOST_DIR=/usr/share/nginx
ENV USER_GUIDE_HOST_DIR=${HOST_DIR}/user_guide
ENV FRONTEND_HOST_DIR=${HOST_DIR}/html

RUN mkdir /etc/nginx/templates
RUN mkdir /etc/nginx/page_templates
Expand Down
4 changes: 2 additions & 2 deletions deploy/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ RUN curl -LO "https://dl.k8s.io/release/$(curl -L -s https://dl.k8s.io/release/s
./get_helm.sh && \
rm kubectl get_helm.sh

ENV HOME /root
ENV PATH ${PATH}:${HOME}/scripts
ENV HOME=/root
ENV PATH=${PATH}:${HOME}/scripts

COPY requirements.txt ${HOME}
RUN pip3 install -r ${HOME}/requirements.txt
Expand Down
2 changes: 1 addition & 1 deletion maintenance/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ RUN chown user:user ${FONT_DIR}
USER user
WORKDIR ${HOME}

ENV PATH ${PATH}:${SCRIPT_DIR}
ENV PATH=${PATH}:${SCRIPT_DIR}

COPY --chown=user:user requirements.txt .

Expand Down

0 comments on commit 8ad50e7

Please sign in to comment.