Fix more pragma warnings

Backend.Tests/Backend.Tests.csproj

@@ -9,7 +9,7 @@
     <AnalysisMode>Recommended</AnalysisMode>
     <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
-    <NoWarn>$(NoWarn);CA1305;CS1591</NoWarn>
+    <NoWarn>$(NoWarn);CA1305;CA1859;CS1591</NoWarn>
   </PropertyGroup>
   <ItemGroup>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />

Backend.Tests/Controllers/LiftControllerTests.cs

@@ -627,9 +627,11 @@ public void TestRoundtrip(RoundTripObj roundTripObj)
             }
         }
 
-        private class MockLogger : ILogger<LiftController>
+        private sealed class MockLogger : ILogger<LiftController>
         {
+#pragma warning disable CS8633
             public IDisposable BeginScope<TState>(TState state)
+#pragma warning restore CS8633
             {
                 throw new NotImplementedException();
             }

Backend.Tests/Mocks/BannerRepositoryMock.cs

@@ -6,7 +6,7 @@
 
 namespace Backend.Tests.Mocks
 {
-    public class BannerRepositoryMock : IBannerRepository
+    internal sealed class BannerRepositoryMock : IBannerRepository
     {
         private Dictionary<BannerType, Banner> _banners;
 

Backend.Tests/Mocks/EmailServiceMock.cs

@@ -4,7 +4,7 @@
 
 namespace Backend.Tests.Mocks
 {
-    internal class EmailServiceMock : IEmailService
+    internal sealed class EmailServiceMock : IEmailService
     {
         public Task<bool> SendEmail(MimeMessage msg)
         {

Backend.Tests/Mocks/MergeBlacklistRepositoryMock.cs

@@ -8,7 +8,7 @@
 
 namespace Backend.Tests.Mocks
 {
-    public class MergeBlacklistRepositoryMock : IMergeBlacklistRepository
+    internal sealed class MergeBlacklistRepositoryMock : IMergeBlacklistRepository
     {
         private readonly List<MergeWordSet> _mergeBlacklist;
 

Backend.Tests/Mocks/MergeGraylistRepositoryMock.cs

@@ -8,7 +8,7 @@
 
 namespace Backend.Tests.Mocks
 {
-    public class MergeGraylistRepositoryMock : IMergeGraylistRepository
+    internal sealed class MergeGraylistRepositoryMock : IMergeGraylistRepository
     {
         private readonly List<MergeWordSet> _mergeGraylist;
 

Backend.Tests/Mocks/PasswordResetServiceMock.cs

@@ -4,7 +4,7 @@
 
 namespace Backend.Tests.Mocks
 {
-    internal class PasswordResetServiceMock : IPasswordResetService
+    internal sealed class PasswordResetServiceMock : IPasswordResetService
     {
         public Task<PasswordReset> CreatePasswordReset(string email)
         {

Backend.Tests/Mocks/PermissionServiceMock.cs

@@ -6,7 +6,7 @@
 
 namespace Backend.Tests.Mocks
 {
-    internal class PermissionServiceMock : IPermissionService
+    internal sealed class PermissionServiceMock : IPermissionService
     {
         private readonly IUserRepository _userRepo;
         private const string NoHttpContextAvailable = "NO_HTTP_CONTEXT_AVAILABLE";

Backend.Tests/Mocks/ProjectRepositoryMock.cs

@@ -9,7 +9,7 @@
 
 namespace Backend.Tests.Mocks
 {
-    public class ProjectRepositoryMock : IProjectRepository
+    internal sealed class ProjectRepositoryMock : IProjectRepository
     {
         private readonly List<Project> _projects;
 

Backend.Tests/Mocks/SemanticDomainRepositoryMock.cs

@@ -5,7 +5,7 @@
 
 namespace Backend.Tests.Mocks
 {
-    public class SemanticDomainRepositoryMock : ISemanticDomainRepository
+    internal sealed class SemanticDomainRepositoryMock : ISemanticDomainRepository
     {
         private object? _responseObj;
 

Backend.Tests/Mocks/SpeakerRepositoryMock.cs

@@ -8,7 +8,7 @@
 
 namespace Backend.Tests.Mocks
 {
-    public class SpeakerRepositoryMock : ISpeakerRepository
+    internal sealed class SpeakerRepositoryMock : ISpeakerRepository
     {
         private readonly List<Speaker> _speakers;
 

Backend.Tests/Mocks/StatisticsServiceMock.cs

@@ -6,7 +6,7 @@
 
 namespace Backend.Tests.Mocks
 {
-    internal class StatisticsServiceMock : IStatisticsService
+    internal sealed class StatisticsServiceMock : IStatisticsService
     {
         public Task<List<SemanticDomainCount>> GetSemanticDomainCounts(string projectId, string lang)
         {

Backend.Tests/Mocks/UserEditRepositoryMock.cs

@@ -7,7 +7,7 @@
 
 namespace Backend.Tests.Mocks
 {
-    public class UserEditRepositoryMock : IUserEditRepository
+    internal sealed class UserEditRepositoryMock : IUserEditRepository
     {
         private readonly List<UserEdit> _userEdits;
 

Backend.Tests/Mocks/UserRepositoryMock.cs

@@ -8,7 +8,7 @@
 
 namespace Backend.Tests.Mocks
 {
-    public class UserRepositoryMock : IUserRepository
+    internal sealed class UserRepositoryMock : IUserRepository
     {
         private readonly List<User> _users;
 
@@ -57,21 +57,21 @@ public Task<bool> Delete(string userId)
 
         public Task<User?> GetUserByEmail(string email, bool sanitize = true)
         {
-            var user = _users.Find(u => u.Email.ToLowerInvariant() == email.ToLowerInvariant());
+            var user = _users.Find(u => u.Email.Equals(email, StringComparison.OrdinalIgnoreCase));
             return Task.FromResult(user);
         }
 
         public Task<User?> GetUserByEmailOrUsername(string emailOrUsername, bool sanitize = true)
         {
             var user = _users.Find(u =>
-                u.Email.ToLowerInvariant() == emailOrUsername.ToLowerInvariant() ||
-                u.Username.ToLowerInvariant() == emailOrUsername.ToLowerInvariant());
+                u.Email.Equals(emailOrUsername, StringComparison.OrdinalIgnoreCase) ||
+                u.Username.Equals(emailOrUsername, StringComparison.OrdinalIgnoreCase));
             return Task.FromResult(user);
         }
 
         public Task<User?> GetUserByUsername(string username, bool sanitize = true)
         {
-            var user = _users.Find(u => u.Username.ToLowerInvariant() == username.ToLowerInvariant());
+            var user = _users.Find(u => u.Username.Equals(username, StringComparison.OrdinalIgnoreCase));
             return Task.FromResult(user);
         }
 

Backend.Tests/Mocks/UserRoleRepositoryMock.cs

@@ -8,7 +8,7 @@
 
 namespace Backend.Tests.Mocks
 {
-    public class UserRoleRepositoryMock : IUserRoleRepository
+    internal sealed class UserRoleRepositoryMock : IUserRoleRepository
     {
         private readonly List<UserRole> _userRoles;
 

Backend.Tests/Mocks/WordRepositoryMock.cs

@@ -7,7 +7,7 @@
 
 namespace Backend.Tests.Mocks
 {
-    public class WordRepositoryMock : IWordRepository
+    internal sealed class WordRepositoryMock : IWordRepository
     {
         private readonly List<Word> _words;
         private readonly List<Word> _frontier;

Backend/Helper/DuplicateFinder.cs

@@ -2,14 +2,13 @@
 using System.Collections.Generic;
 using System.Linq;
 using System.Threading.Tasks;
-using BackendFramework.Interfaces;
 using BackendFramework.Models;
 
 namespace BackendFramework.Helper
 {
     public class DuplicateFinder
     {
-        private readonly IEditDistance _editDist;
+        private readonly LevenshteinDistance _editDist;
         private readonly int _maxInList;
         private readonly int _maxLists;
         private readonly int _maxScore;

Backend/Repositories/UserRepository.cs

@@ -118,7 +118,7 @@ public async Task<bool> Delete(string userId)
         public async Task<User?> GetUserByEmail(string email, bool sanitize = true)
         {
             var user = (await _userDatabase.Users.FindAsync(
-                x => x.Email.ToLowerInvariant() == email.ToLowerInvariant())).FirstOrDefault();
+                x => x.Email.Equals(email, StringComparison.OrdinalIgnoreCase))).FirstOrDefault();
             if (sanitize && user is not null)
             {
                 user.Sanitize();
@@ -131,8 +131,9 @@ public async Task<bool> Delete(string userId)
         public async Task<User?> GetUserByEmailOrUsername(string emailOrUsername, bool sanitize = true)
         {
             var lower = emailOrUsername.ToLowerInvariant();
-            var user = (await _userDatabase.Users.FindAsync(
-                u => u.Username.ToLowerInvariant() == lower || u.Email.ToLowerInvariant() == lower)).FirstOrDefault();
+            var user = (await _userDatabase.Users.FindAsync(u =>
+                u.Username.Equals(emailOrUsername, StringComparison.OrdinalIgnoreCase) ||
+                u.Email.Equals(emailOrUsername, StringComparison.OrdinalIgnoreCase))).FirstOrDefault();
             if (sanitize && user is not null)
             {
                 user.Sanitize();
@@ -145,7 +146,7 @@ public async Task<bool> Delete(string userId)
         public async Task<User?> GetUserByUsername(string username, bool sanitize = true)
         {
             var user = (await _userDatabase.Users.FindAsync(
-                x => x.Username.ToLowerInvariant() == username.ToLowerInvariant())).FirstOrDefault();
+                x => x.Username.Equals(username, StringComparison.OrdinalIgnoreCase))).FirstOrDefault();
             if (sanitize && user is not null)
             {
                 user.Sanitize();
@@ -171,12 +172,12 @@ public async Task<ResultOfUpdate> Update(string userId, User user, bool updateIs
             }
 
             // Confirm that email and username aren't taken by another user.
-            if (user.Email.ToLowerInvariant() != oldUser.Email.ToLowerInvariant()
+            if (!user.Email.Equals(oldUser.Email, StringComparison.OrdinalIgnoreCase)
                 && await GetUserByEmail(user.Email) is not null)
             {
                 return ResultOfUpdate.Failed;
             }
-            if (user.Username.ToLowerInvariant() != oldUser.Username.ToLowerInvariant()
+            if (!user.Username.Equals(oldUser.Username, StringComparison.OrdinalIgnoreCase)
                 && await GetUserByUsername(user.Username) is not null)
             {
                 return ResultOfUpdate.Failed;

Backend/Services/PasswordResetService.cs

@@ -45,7 +45,7 @@ public async Task<bool> ResetPassword(string token, string password)
                 return false;
             }
             var user = (await _userRepo.GetAllUsers()).Single(u =>
-                u.Email.ToLowerInvariant() == request.Email.ToLowerInvariant());
+                u.Email.Equals(request.Email, StringComparison.OrdinalIgnoreCase));
             await _userRepo.ChangePassword(user.Id, password);
             await ExpirePasswordReset(request.Email);
             return true;

Backend/Services/StatisticsService.cs

@@ -200,12 +200,11 @@ public async Task<ChartRootData> GetProgressEstimationLineChartRoot(string proje
             {
                 LineChartData.Dates.Add(workshopSchedule[i]);
                 var day = workshopSchedule[i];
+                totalCountDictionary.TryGetValue(day, out today);
                 if (LineChartData.Datasets.Count == 0)
                 {
-                    runningTotal = totalCountDictionary.ContainsKey(day) ? totalCountDictionary[day] : 0;
-                    today = yesterday = runningTotal;
-                    LineChartData.Datasets.Add(new Dataset(
-                        "Daily Total", totalCountDictionary.ContainsKey(day) ? totalCountDictionary[day] : 0));
+                    runningTotal = yesterday = today;
+                    LineChartData.Datasets.Add(new Dataset("Daily Total", today));
                     LineChartData.Datasets.Add(new Dataset("Average", averageValue));
                     LineChartData.Datasets.Add(new Dataset("Running Total", runningTotal));
                     LineChartData.Datasets.Add(new Dataset("Projection", projection));
@@ -216,7 +215,6 @@ public async Task<ChartRootData> GetProgressEstimationLineChartRoot(string proje
                     // not generate data after the current date for "Daily Total", "Average" and "Running Total"
                     if (ParseDateTimePermissivelyWithException(day).CompareTo(DateTime.Now) <= 0)
                     {
-                        today = totalCountDictionary.ContainsKey(day) ? totalCountDictionary[day] : 0;
                         runningTotal += today;
                         LineChartData.Datasets.Find(element => element.UserName == "Daily Total")?.Data.Add(today);
                         LineChartData.Datasets.Find(element => element.UserName == "Average")?.Data.Add(averageValue);
@@ -330,9 +328,8 @@ public async Task<List<SemanticDomainUserCount>> GetSemanticDomainUserCounts(str
                         }
 
                         // update DomainCount
-                        if (!domainUserValue.DomainSet.Contains(domainName))
+                        if (domainUserValue.DomainSet.Add(domainName))
                         {
-                            domainUserValue.DomainSet.Add(domainName);
                             domainUserValue.DomainCount++;
                         }
                         // update WordCount

Backend/Startup.cs

@@ -148,8 +148,10 @@ public void ConfigureServices(IServiceCollection services)
                 options =>
                 {
                     var connectionStringKey = IsInContainer() ? "ContainerConnectionString" : "ConnectionString";
-                    options.ConnectionString = Configuration[$"MongoDB:{connectionStringKey}"];
-                    options.CombineDatabase = Configuration["MongoDB:CombineDatabase"];
+                    options.ConnectionString = Configuration[$"MongoDB:{connectionStringKey}"]
+                        ?? throw new EnvironmentNotConfiguredException();
+                    options.CombineDatabase = Configuration["MongoDB:CombineDatabase"]
+                        ?? throw new EnvironmentNotConfiguredException();
 
                     const string emailServiceFailureMessage = "Email services will not work.";
                     options.SmtpServer = CheckedEnvironmentVariable(