Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the trusted-signing-service in build-test-installer-release.yml #123

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

tim-eves
Copy link
Contributor

Switch from the codesign v2 reusable workflow to the v3 trusted-signing-action.

Switch from the codesign v2 reusable workflow to the v3 trusted-signing-action.
@tim-eves tim-eves added enhancement github_actions Pull requests that update GitHub Actions code labels Oct 10, 2024
@tim-eves tim-eves requested a review from hahn-kev October 10, 2024 07:02
Copy link
Contributor

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. I made my own change to ensure the installer is always built so we don't find out it's broken after the merge

@tim-eves tim-eves merged commit e9df97c into master Oct 15, 2024
2 checks passed
@tim-eves tim-eves deleted the feat/update-siging-step-to-trusted-signing branch October 15, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants