Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pushing tags #15

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Pushing tags #15

merged 3 commits into from
Oct 30, 2024

Conversation

Praveenraj-K
Copy link
Contributor

Changed

  • removed the branch tagging
  • added the semver tagging

@Praveenraj-K Praveenraj-K requested a review from a team October 30, 2024 08:29
briskt
briskt requested changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@briskt briskt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. The build-and-publish job should have an if: startsWith(github.ref, 'refs/tags') line to prevent running on a branch push. Thanks for noticing the docker-compose that slipped through the cracks!

@Praveenraj-K
Copy link
Contributor Author

Looks good so far. The build-and-publish job should have an if: startsWith(github.ref, 'refs/tags') line to prevent running on a branch push. Thanks for noticing the docker-compose that slipped through the cracks!

Got it, added :)

@Praveenraj-K Praveenraj-K reopened this Oct 30, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Praveenraj-K Praveenraj-K requested a review from briskt October 30, 2024 08:56
@Praveenraj-K Praveenraj-K merged commit 840428b into main Oct 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briskt briskt briskt approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Praveenraj-K @briskt