Update CI #11
Merged
Update CI #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
wjymtg
commented
Dec 13, 2024
wjymtg
commented
- flaky&failed tests通过toPass循环基本解决了（但根本原因依然未知，我本地无法复现），现在可能还会有一小部分flaky
- 去除了update的主分支PR合并触发，因为能合并说明测试通过了也没必要更新对比图了。
- 我之前发现有一些对比图片里没有节点，调查了下是因为用显示名称搜索的话会遇到输入了全称反而搜索不到的情况，我看应该是comfyui frontend使用的fuzzy search库的问题，可能和这个issue类似。在它的demo网站试了下没有复现，也可能和其他搜索选项有关。不过无论如何都是我们自己没法解决的，就只能使用类名称搜索了
- 注：发现action定义在主分支之后就可以随便在其他分支上跑，不仅限于主分支。
wjymtg
commented
Dec 13, 2024
Comment on lines
+145
to
+151
| // NOTE: not elegant but for BizyAirToggleServerEndpoint it clicks on its dropdown so need some | ||
| // offset while not breaking the others. | ||
| let y = 350; | ||
| if (nodeName === "BizyAirToggleServerEndpoint") { | ||
| y = 370; | ||
| } | ||
| await page.mouse.move(700, y); |
There was a problem hiding this comment.
这个节点会点到选项上导致没有移动，所以坐标需要些许下移
wjymtg
commented
Dec 13, 2024
| await page.mouse.up(); | ||
| await expect(page).toHaveScreenshot(`move_${nodeName}.png`, { | ||
| maxDiffPixelRatio: 0.01, | ||
| threshold: 0.1, |
There was a problem hiding this comment.
默认threshold 0.2会导致右上角API错误红框都识别不出来
* Update test expectations [skip ci] * rm old snapshots * Update test expectations [skip ci] --------- Co-authored-by: wjymtg <[email protected]>
doombeaker
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.