Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test header and semver ci #304

Merged
merged 13 commits into from
Jan 8, 2025
Merged

Add test header and semver ci #304

merged 13 commits into from
Jan 8, 2025

Conversation

wjymtg
Copy link
Contributor

@wjymtg wjymtg commented Jan 8, 2025

ci 已经成功跑过 in #302
#302#303,#304是为了测试semver ci触发,semver ci action 4 & 5 证明在PR创建时加上的label和后来再加的一样都可以触发labeled事件,所以不需要额外检查PR opened

将来如果需要,在提交PR时(或者之后)加上major/minor/patch标签即可(现在我只创建了patch,所以版本号是0.4.0->0.4.2)

@wjymtg wjymtg added the patch label Jan 8, 2025
@dantegarden dantegarden merged commit cd569fb into master Jan 8, 2025
1 of 3 checks passed
@dantegarden dantegarden deleted the add_header branch January 8, 2025 06:39

from .errno import ErrorNo, errnos
from .error_handler import ErrorHandler
from .utils import is_string_valid

CLIENT_VERSION = "v20241029"
with open(f"{os.path.dirname(__file__)}/../../version.txt", "r") as file:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的路径拼接,需要改成使用 os.path.join 方法的拼接,否则 windows 下可能出现不兼容的情况(win下的分隔符是 '\')

python-version: '3.10'

- name: Install dependencies
run: pip install semver argparse
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argparse 是标准库,不需要单独安装

@wjymtg wjymtg mentioned this pull request Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants