-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test header and semver ci #304
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doombeaker
approved these changes
Jan 8, 2025
|
||
from .errno import ErrorNo, errnos | ||
from .error_handler import ErrorHandler | ||
from .utils import is_string_valid | ||
|
||
CLIENT_VERSION = "v20241029" | ||
with open(f"{os.path.dirname(__file__)}/../../version.txt", "r") as file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的路径拼接,需要改成使用 os.path.join 方法的拼接,否则 windows 下可能出现不兼容的情况(win下的分隔符是 '\')
python-version: '3.10' | ||
|
||
- name: Install dependencies | ||
run: pip install semver argparse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
argparse
是标准库,不需要单独安装
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ci 已经成功跑过 in #302
#302,#303,#304是为了测试semver ci触发,semver ci action 4 & 5 证明在PR创建时加上的label和后来再加的一样都可以触发labeled事件,所以不需要额外检查PR opened
将来如果需要,在提交PR时(或者之后)加上major/minor/patch标签即可(现在我只创建了patch,所以版本号是0.4.0->0.4.2)