fix: make init now dry run friendly (#110)

* fix: make init now dry run friendly * tests: make init tests
sigwinhq · Jan 31, 2023 · 49b28f7 · 49b28f7
1 parent aa0a49c
commit 49b28f7
Show file tree

Hide file tree

Showing 7 changed files with 65 additions and 1 deletion.
diff --git a/resources/Common/default.mk b/resources/Common/default.mk
@@ -46,7 +46,8 @@ else
 endif
 
 define dir_copy
-$(shell if [ -d "${1}" ]; then cp -a ${1}/. .; fi)
+if [ -d "${1}" ]; then cp -a ${1}/. .; fi
+
 endef
 
 define str_reverse

diff --git a/tests/functional/Common/DefaultTest.php b/tests/functional/Common/DefaultTest.php
@@ -24,6 +24,14 @@
  */
 final class DefaultTest extends MakefileTestCase
 {
+    protected function getExpectedInitPaths(): array
+    {
+        return [
+            'Common/Platform/$PLATFORM/default',
+            'Common/default',
+        ];
+    }
+
     protected function getExpectedHelpCommandsExecutionPath(): array
     {
         return [

diff --git a/tests/functional/MakefileTestCase.php b/tests/functional/MakefileTestCase.php
@@ -54,6 +54,8 @@ abstract class MakefileTestCase extends TestCase
 
     abstract protected function getExpectedHelpCommandsExecutionPath(): array;
 
+    abstract protected function getExpectedInitPaths(): array;
+
     protected function getExpectedHelp(): string
     {
         return $this->generateHelpList(array_keys($this->getExpectedHelpCommandsExecutionPath()));
@@ -86,6 +88,14 @@ public function testHelpIsTheDefaultCommand(): void
         static::assertSame($expected, $actual);
     }
 
+    public function testMakefileHasInit(): void
+    {
+        $expected = array_map(static fn (string $path): string => sprintf('if [ -d "$ROOT/resources/%1$s" ]; then cp -a $ROOT/resources/%1$s/. .; fi', $path), $this->getExpectedInitPaths());
+        $actual = $this->dryRun($this->getMakefilePath(), 'init');
+
+        static::assertSame($expected, $actual);
+    }
+
     /**
      * @dataProvider generateHelpCommandsExecutionPathFixtures
      */

diff --git a/tests/functional/PHP/LibraryTest.php b/tests/functional/PHP/LibraryTest.php
@@ -26,6 +26,16 @@ final class LibraryTest extends MakefileTestCase
 {
     use PhpTrait;
 
+    protected function getExpectedInitPaths(): array
+    {
+        return [
+            'Common/Platform/$PLATFORM/default',
+            'Common/default',
+            'PHP/common',
+            'PHP/library',
+        ];
+    }
+
     protected function getExpectedHelpCommandsExecutionPath(): array
     {
         $mkdir = $this->paths()['mkdir: phpqa'];

diff --git a/tests/functional/Pimcore/ApplicationTest.php b/tests/functional/Pimcore/ApplicationTest.php
@@ -63,6 +63,17 @@ protected function tearDown(): void
         ]);
     }
 
+    protected function getExpectedInitPaths(): array
+    {
+        return [
+            'Common/Platform/$PLATFORM/default',
+            'Common/default',
+            'PHP/common',
+            'Pimcore/common',
+            'Pimcore/application',
+        ];
+    }
+
     protected function getExpectedHelpCommandsExecutionPath(): array
     {
         $mkdir = $this->paths()['mkdir: phpqa'];

diff --git a/tests/functional/Pimcore/LibraryTest.php b/tests/functional/Pimcore/LibraryTest.php
@@ -27,6 +27,17 @@ final class LibraryTest extends MakefileTestCase
 {
     use PhpTrait;
 
+    protected function getExpectedInitPaths(): array
+    {
+        return [
+            'Common/Platform/$PLATFORM/default',
+            'Common/default',
+            'PHP/common',
+            'Pimcore/common',
+            'Pimcore/library',
+        ];
+    }
+
     protected function getExpectedHelpCommandsExecutionPath(): array
     {
         $mkdir = $this->paths()['mkdir: phpqa'];

diff --git a/tests/functional/YASSG/CompatTest.php b/tests/functional/YASSG/CompatTest.php
@@ -31,6 +31,19 @@ final class CompatTest extends MakefileTestCase
         'start' => 'Start app in APP_ENV mode (defaults to "dev")',
     ];
 
+    protected function getExpectedInitPaths(): array
+    {
+        return [
+            'Common/Platform/$PLATFORM/default',
+            'Common/default',
+            'PHP/common',
+            'Lighthouse/common',
+            'Visual/common',
+            'YASSG/common',
+            'YASSG/compat',
+        ];
+    }
+
     protected function getExpectedHelpCommandsExecutionPath(): array
     {
         $mkdir = $this->paths()['mkdir: phpqa'];