Fix generation when a method is called "request".

sigurdm · Nov 3, 2016 · 5f24f72 · 5f24f72
1 parent a00b505
commit 5f24f72
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/lib/service_generator.dart b/lib/service_generator.dart
@@ -166,7 +166,8 @@ class ServiceGenerator {
       out.addBlock("switch (method) {", "}", () {
         for (MethodDescriptorProto m in _methodDescriptors) {
           var methodName = _methodName(m.name);
-          out.println("case '${m.name}': return $methodName(ctx, request);");
+          out.println(
+              "case '${m.name}': return this.$methodName(ctx, request);");
         }
         out.println("default: "
             "throw new ArgumentError('Unknown method: \$method');");

diff --git a/test/file_generator_test.dart b/test/file_generator_test.dart
@@ -371,7 +371,7 @@ abstract class TestServiceBase extends GeneratedService {
 
   Future<GeneratedMessage> handleCall(ServerContext ctx, String method, GeneratedMessage request) {
     switch (method) {
-      case 'Ping': return ping(ctx, request);
+      case 'Ping': return this.ping(ctx, request);
       default: throw new ArgumentError('Unknown method: $method');
     }
   }

diff --git a/test/service_generator_test.dart b/test/service_generator_test.dart
@@ -28,8 +28,8 @@ abstract class TestServiceBase extends GeneratedService {
 
   Future<GeneratedMessage> handleCall(ServerContext ctx, String method, GeneratedMessage request) {
     switch (method) {
-      case 'AMethod': return aMethod(ctx, request);
-      case 'AnotherMethod': return anotherMethod(ctx, request);
+      case 'AMethod': return this.aMethod(ctx, request);
+      case 'AnotherMethod': return this.anotherMethod(ctx, request);
       default: throw new ArgumentError('Unknown method: $method');
     }
   }