Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump go to use v1.23 #831

Merged
merged 3 commits into from
Sep 25, 2024
Merged

chore: bump go to use v1.23 #831

merged 3 commits into from
Sep 25, 2024

Conversation

hectorj2f
Copy link
Contributor

I am bumping our go version to use 1.23 so we can solve some CVEs and upgrade our go version to latest.

@hectorj2f hectorj2f requested a review from a team as a code owner September 25, 2024 08:05
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.92%. Comparing base (6fd19b0) to head (74c3758).
Report is 175 commits behind head on main.

Files with missing lines Patch % Lines
pkg/signer/tink.go 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #831      +/-   ##
==========================================
- Coverage   52.85%   45.92%   -6.94%     
==========================================
  Files          20       55      +35     
  Lines        1209     2942    +1733     
==========================================
+ Hits          639     1351     +712     
- Misses        509     1451     +942     
- Partials       61      140      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also bump https://github.com/sigstore/timestamp-authority/blob/main/.github/workflows/tests.yaml#L98 to the latest minor, i think it is v1.61

@cpanato cpanato merged commit 7a56c89 into sigstore:main Sep 25, 2024
8 checks passed
@hectorj2f hectorj2f deleted the use_go123 branch September 25, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants