Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to go1.22 and other updates #722

Merged
merged 9 commits into from
May 14, 2024
Merged

Upgrade to go1.22 and other updates #722

merged 9 commits into from
May 14, 2024

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented May 2, 2024

Summary

  • upgrade to go1.22
  • add job to build with gorelease to test the flow
  • group dependabot updates
  • drop job that is not useful

Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 46.39%. Comparing base (6fd19b0) to head (0e4471e).
Report is 92 commits behind head on main.

Files Patch % Lines
cmd/fetch-tsa-certs/fetch_tsa_certs.go 0.00% 2 Missing ⚠️
cmd/timestamp-cli/app/inspect.go 0.00% 2 Missing ⚠️
cmd/timestamp-cli/app/timestamp.go 0.00% 2 Missing ⚠️
cmd/timestamp-cli/app/verify.go 0.00% 2 Missing ⚠️
cmd/timestamp-cli/app/format/wrap.go 0.00% 0 Missing and 1 partial ⚠️
cmd/timestamp-cli/app/root.go 0.00% 1 Missing ⚠️
cmd/timestamp-server/app/serve.go 0.00% 1 Missing ⚠️
pkg/signer/signer.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #722      +/-   ##
==========================================
- Coverage   52.85%   46.39%   -6.47%     
==========================================
  Files          20       55      +35     
  Lines        1209     2910    +1701     
==========================================
+ Hits          639     1350     +711     
- Misses        509     1420     +911     
- Partials       61      140      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpanato cpanato force-pushed the upgrade branch 4 times, most recently from b34af70 to d266de2 Compare May 7, 2024 12:10
@cpanato cpanato marked this pull request as ready for review May 7, 2024 12:34
@cpanato cpanato requested a review from a team as a code owner May 7, 2024 12:34
.goreleaser.yml Outdated Show resolved Hide resolved
@cpanato cpanato requested a review from haydentherapper May 8, 2024 17:38
haydentherapper
haydentherapper previously approved these changes May 8, 2024
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Have you tested this release on a fork to confirm the GHAs are working as expected?

@cpanato
Copy link
Member Author

cpanato commented May 13, 2024

Thank you! Have you tested this release on a fork to confirm the GHAs are working as expected?

will do that just to confirm :)

@cpanato
Copy link
Member Author

cpanato commented May 13, 2024

@cpanato cpanato merged commit 0cf97a5 into sigstore:main May 14, 2024
8 checks passed
@cpanato cpanato deleted the upgrade branch May 14, 2024 13:14
@cpanato cpanato mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants