Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sigstore, test: break apart DSSE/artifact sign APIs #956

Merged
merged 12 commits into from
Apr 12, 2024
Merged

Conversation

woodruffw
Copy link
Member

Per #628: this turns sign(...) into sign_artifact(...) and sign_intoto(...) respectively. In doing so, we're also able to simplify and deduplicate the internals of the Signer class a bit.

@woodruffw woodruffw added the refactoring Refactoring tasks. label Apr 3, 2024
@woodruffw woodruffw self-assigned this Apr 3, 2024
Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw added this to the 3.0 milestone Apr 3, 2024
@woodruffw woodruffw marked this pull request as ready for review April 3, 2024 17:54
sigstore/sign.py Outdated Show resolved Hide resolved
Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw requested a review from jku April 4, 2024 14:23
Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. I just have docstring and changelog nitpicks.

The changelog rewrite could be left as its own issue: we'll need to review it anyway since you've done so much on this release.

sigstore/sign.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@woodruffw
Copy link
Member Author

The changelog rewrite could be left as its own issue: we'll need to review it anyway since you've done so much on this release.

Yeah, good call. I'll stop updating it with these PRs and file a separate tracker for doing a big update pre-release 🙂

@woodruffw woodruffw requested a review from jku April 5, 2024 17:31
@woodruffw woodruffw mentioned this pull request Apr 5, 2024
3 tasks
@woodruffw woodruffw enabled auto-merge (squash) April 12, 2024 14:03
@woodruffw woodruffw merged commit 4ad35d1 into main Apr 12, 2024
25 checks passed
@woodruffw woodruffw deleted the ww/sign-split branch April 12, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants