-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sigstore, test: break apart DSSE/artifact sign APIs #956
Conversation
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good. I just have docstring and changelog nitpicks.
The changelog rewrite could be left as its own issue: we'll need to review it anyway since you've done so much on this release.
Yeah, good call. I'll stop updating it with these PRs and file a separate tracker for doing a big update pre-release 🙂 |
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Per #628: this turns
sign(...)
intosign_artifact(...)
andsign_intoto(...)
respectively. In doing so, we're also able to simplify and deduplicate the internals of theSigner
class a bit.