Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rekor: use sigstore_rekor_types for models #788

Merged
merged 15 commits into from
Oct 6, 2023
Merged

rekor: use sigstore_rekor_types for models #788

merged 15 commits into from
Oct 6, 2023

Conversation

woodruffw
Copy link
Member

@woodruffw woodruffw commented Oct 3, 2023 •
edited
Loading

WIP.

Towards #628.

@woodruffw woodruffw added enhancement New feature or request component:signing Core signing functionality component:verification Core verification functionality labels Oct 3, 2023
@woodruffw woodruffw self-assigned this Oct 3, 2023
woodruffw added 12 commits October 4, 2023 10:58
@woodruffw
pyproject: sigstore-rekor-types 0.0.2
02a5416 
Signed-off-by: William Woodruff <[email protected]>
@woodruffw
pyproject: bump sigstore-rekor-types
2e8872e 
Signed-off-by: William Woodruff <[email protected]>
@woodruffw
sign: fix API usage
6f8ea39 
Signed-off-by: William Woodruff <[email protected]>
@woodruffw
rekor/client: debugging
cabd3a3 
Signed-off-by: William Woodruff <[email protected]>
@woodruffw
Revert "rekor/client: debugging"
deda26c 
This reverts commit cabd3a3.
@woodruffw
rekor/client: use field aliases
e210943 
Signed-off-by: William Woodruff <[email protected]>
@woodruffw
sigstore: bump sigstore_rekor_types, refactor
3649e57 
Signed-off-by: William Woodruff <[email protected]>
@woodruffw
pyproject: bump sigstore-rekor-types
b165a7b 
Signed-off-by: William Woodruff <[email protected]>
@woodruffw
pyproject: the bumping continues
8926937 
Signed-off-by: William Woodruff <[email protected]>
@woodruffw
sign: fix type
1c0803a 
Annoying.

Signed-off-by: William Woodruff <[email protected]>
@woodruffw
sign: another typo
f7aef97 
Signed-off-by: William Woodruff <[email protected]>
@woodruffw
bump again, rename
e8cc086 
Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw marked this pull request as ready for review October 4, 2023 19:03
@woodruffw woodruffw requested a review from di October 4, 2023 19:03
@woodruffw
Copy link
Member Author

This is the first part towards #628: we now use sigstore_rekor_types for Rekor API models, which will reduce the amount of (error-prone) manual payload construction we need to do.

@woodruffw woodruffw mentioned this pull request Oct 4, 2023
Closed
9 tasks
@woodruffw
remove more hardcoded models
bb3f01a 
Signed-off-by: William Woodruff <[email protected]>
@woodruffw
verify/models: reflow comments
ecd70b3 
Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw merged commit a16aed9 into main Oct 6, 2023
@woodruffw woodruffw deleted the ww/dsse-models branch October 6, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@di di di approved these changes

Assignees

@woodruffw woodruffw

Labels
component:signing Core signing functionality component:verification Core verification functionality enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woodruffw @di