Grant TUF SA access to modify storage objects #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to use the TUF SA on GitHub Actions workflows. Signed-off-by: Hayden Blauzvern <[email protected]>
jku
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Looks correct.
For completeness (assuming we don't try to find another solution) we're also going to need roles/compute.loadBalancerAdmin or more specifically compute.urlMaps.invalidateCache permission but that is not really related to the bucket so this change seems good to me.
cpanato
approved these changes
Jan 19, 2024
| member = format("serviceAccount:%s@%s.iam.gserviceaccount.com", var.tuf_service_account_name, var.project_id) | ||
|
|
||
| depends_on = [google_storage_bucket.tuf_preprod, google_service_account.tuf-sa] | ||
| } |
Planning to grant that in the private repo since the load balancer configuration isn't in scaffolding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to use the TUF SA on GitHub Actions workflows.
Summary
Release Note
Documentation