Revert #888 -- our alerting rule was not correct. #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evan Anderson <[email protected]>
evankanderson
changed the title
It turns out that the value we have is a gauge, not a counter. When we try use a counter, we don't detect the edge from "not collected" to "1", so the alert doesn't work. This reverts commit a1937fd. Signed-off-by: Evan Anderson <[email protected]>
pwelch
approved these changes
Dec 5, 2023
evankanderson
force-pushed
the
delta-validation-counter
branch
from
f43a7e5 to
5d30466
Compare
hectorj2f
approved these changes
Dec 5, 2023
|
See #890 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Release Note
Reverts #888
Documentation