Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve error logs for prober #886

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Conversation

hectorj2f
Copy link
Contributor

Summary

@bobcallaway found that the error logs of the prober weren't giving much information of what was happening. We also need to check the response code.

Release Note

Documentation

Signed-off-by: Hector Fernandez <[email protected]>
@hectorj2f hectorj2f requested a review from bobcallaway December 5, 2023 13:43
@hectorj2f hectorj2f self-assigned this Dec 5, 2023
cmd/prober/write.go Outdated Show resolved Hide resolved
cmd/prober/write.go Outdated Show resolved Hide resolved
cmd/prober/write.go Outdated Show resolved Hide resolved
@hectorj2f hectorj2f requested a review from bobcallaway December 5, 2023 16:51
cmd/prober/write.go Outdated Show resolved Hide resolved
cmd/prober/write.go Outdated Show resolved Hide resolved
Signed-off-by: Hector Fernandez <[email protected]>
@hectorj2f hectorj2f enabled auto-merge (squash) December 5, 2023 16:58
@hectorj2f hectorj2f merged commit f2b97f5 into sigstore:main Dec 5, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants