Add database for rekor search indexes #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the mysql and rekor modules to instantiate a new database in the primary SQL instance for search index storage. The rekor IAM service accounts are bound to their GKE equivalents and given permission to access the Cloud SQL instance, which makes the cloud-sql-proxy sidecar in the Rekor deployment work. The "trillian" database instance resource is renamed to "sigstore" since the instance now encompasses two databases, one of which is not for trillian. The mysql module creates a trillian mysql user, which is not an IAM user. This user already has effectively admin grants on the SQL instance, so it is capable of connecting to the new instance and creating a new user named for the new database would not reduce the overall privileges, so we reuse the trillian mysql user for the new database. Signed-off-by: Colleen Murphy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the mysql and rekor modules to instantiate a new database in the primary SQL instance for search index storage.
The rekor IAM service accounts are bound to their GKE equivalents and given permission to access the Cloud SQL instance, which makes the cloud-sql-proxy sidecar in the Rekor deployment work.
The "trillian" database instance resource is renamed to "sigstore" since the instance now encompasses two databases, one of which is not for trillian.
The mysql module creates a trillian mysql user, which is not an IAM user. This user already has effectively admin grants on the SQL instance, so it is capable of connecting to the new instance and creating a new user named for the new database would not reduce the overall privileges, so we reuse the trillian mysql user for the new database.
Summary
Release Note
Documentation