refactors

Signed-off-by: Javan lacerda <[email protected]>

cmd/prober/write.go

@@ -139,21 +139,21 @@ func fulcioWriteEndpoint(ctx context.Context, priv *ecdsa.PrivateKey) (*x509.Cer
 	return cert[0], nil
 }
 
-func makeRekorRequest(cert *x509.Certificate, priv *ecdsa.PrivateKey, hostPath string) (*http.Response, time.Time, error) {
+func makeRekorRequest(cert *x509.Certificate, priv *ecdsa.PrivateKey, hostPath string) (*http.Response, int64, error) {
 	body, err := rekorEntryRequest(cert, priv)
-	t := time.Now()
 	if err != nil {
-		return nil, t, fmt.Errorf("rekor entry: %w", err)
+		return nil, -1, fmt.Errorf("rekor entry: %w", err)
 	}
 	req, err := retryablehttp.NewRequest(http.MethodPost, hostPath, bytes.NewBuffer(body))
 	if err != nil {
-		return nil, t, fmt.Errorf("new request: %w", err)
+		return nil, -1, fmt.Errorf("new request: %w", err)
 	}
 	setHeaders(req, "")
 
-	t = time.Now()
+	t := time.Now()
 	resp, err := retryableClient.Do(req)
-	return resp, t, err
+	latency := time.Since(t).Milliseconds()
+	return resp, latency, err
 }
 
 // rekorWriteEndpoint tests the write endpoint for rekor, which is
@@ -167,24 +167,20 @@ func rekorWriteEndpoint(ctx context.Context, cert *x509.Certificate, priv *ecdsa
 	defer func() {
 		verificationCounter.With(prometheus.Labels{verifiedLabel: verified}).Inc()
 	}()
-
-	resp, t, err := makeRekorRequest(cert, priv, hostPath)
-	if err != nil {
-		return fmt.Errorf("error adding entry: %w", err)
-	}
-	defer resp.Body.Close()
+	var resp *http.Response
+	var latency int64
+	var err error
 	// A new body should be created when it is conflicted
-	for {
-		if resp.StatusCode != http.StatusConflict {
-			break
-		}
-		resp, t, err = makeRekorRequest(cert, priv, hostPath)
+	for i := 1; i < 10; i++ {
+		resp, latency, err = makeRekorRequest(cert, priv, hostPath)
 		if err != nil {
 			return fmt.Errorf("error adding entry: %w", err)
 		}
 		defer resp.Body.Close()
+		if resp.StatusCode != http.StatusConflict {
+			break
+		}
 	}
-	latency := time.Since(t).Milliseconds()
 	exportDataToPrometheus(resp, rekorURL, endpoint, POST, latency)
 
 	if resp.StatusCode != http.StatusCreated {