Skip to content

Commit

Permalink
change default mysql version from 8.0 to 5.7 (#180)
Browse files Browse the repository at this point in the history
This makes it configurable as well.

The default change is due to performance issue with large amount of data, where large amount of data is a copy of the current sigstore prod database.

Signed-off-by: Kenny Leung <[email protected]>
  • Loading branch information
k4leung4 authored May 27, 2022
1 parent 1e0922b commit 2c908ac
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 2 deletions.
5 changes: 5 additions & 0 deletions terraform/gcp/modules/mysql/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -92,3 +92,8 @@ variable "db_name" {
default = "trillian"
}

variable "database_version" {
type = string
description = "MySQL database version."
default = "MYSQL_5_7"
}
1 change: 1 addition & 0 deletions terraform/gcp/modules/sigstore/sigstore.tf
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ module "mysql" {
project_id = var.project_id

cluster_name = var.cluster_name
database_version = var.mysql_db_version
tier = var.mysql_tier
availability_type = var.mysql_availability_type

Expand Down
8 changes: 6 additions & 2 deletions terraform/gcp/modules/sigstore/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,12 @@ variable "mysql_db_name" {
default = "trillian"
}

variable "mysql_db_version" {
type = string
description = "MySQL database version."
default = "MYSQL_5_7"
}

variable "mysql_tier" {
type = string
description = "Machine tier for MySQL instance."
Expand Down Expand Up @@ -161,8 +167,6 @@ variable "mysql_binary_log_backup_enabled" {
default = true
}



variable "fulcio_keyring_name" {
type = string
description = "Name of Fulcio keyring."
Expand Down

0 comments on commit 2c908ac

Please sign in to comment.