Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message when computing consistency proof #2278

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

haydentherapper
Copy link
Contributor

The service would panic if firstSize > lastSize because the error object was not created.

Summary

Release Note

Documentation

The service would panic if firstSize > lastSize because the error
object was not created.

Signed-off-by: Hayden Blauzvern <[email protected]>
@haydentherapper haydentherapper requested a review from a team as a code owner November 19, 2024 03:39
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 49.90%. Comparing base (488eb97) to head (f2dbac2).
Report is 239 commits behind head on main.

Files with missing lines Patch % Lines
pkg/api/tlog.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2278       +/-   ##
===========================================
- Coverage   66.46%   49.90%   -16.57%     
===========================================
  Files          92      192      +100     
  Lines        9258    24677    +15419     
===========================================
+ Hits         6153    12314     +6161     
- Misses       2359    11272     +8913     
- Partials      746     1091      +345     
Flag Coverage Δ
e2etests 46.52% <0.00%> (-1.03%) ⬇️
unittests 41.91% <0.00%> (-5.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@bobcallaway bobcallaway merged commit 56ea4b5 into sigstore:main Nov 19, 2024
15 checks passed
@github-actions github-actions bot added this to the v1.2.2 milestone Nov 19, 2024
@haydentherapper haydentherapper deleted the fix-crash branch November 19, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants