Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump image versions in docker compose #1828

Closed
wants to merge 2 commits into from

Conversation

haydentherapper
Copy link
Contributor

Summary

Release Note

Documentation

@haydentherapper haydentherapper requested a review from a team as a code owner November 14, 2023 21:54
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5383621) 66.40% compared to head (e2fbfdb) 66.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1828      +/-   ##
==========================================
- Coverage   66.40%   66.37%   -0.03%     
==========================================
  Files          90       90              
  Lines        9057     9057              
==========================================
- Hits         6014     6012       -2     
- Misses       2309     2311       +2     
  Partials      734      734              
Flag Coverage Δ
e2etests 47.92% <ø> (ø)
unittests 47.33% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -31,7 +31,7 @@ services:
retries: 3
start_period: 10s
redis-server:
image: docker.io/redis:6.2
image: docker.io/redis:7.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd leave this at v6 since this matches the version we use elsewhere

Signed-off-by: Hayden B <[email protected]>
bobcallaway
bobcallaway previously approved these changes Nov 14, 2023
@bobcallaway bobcallaway enabled auto-merge (squash) November 14, 2023 22:50
Copy link
Member

@bobcallaway bobcallaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need to figure out a workaround for the harness tests. the DB upgrade in the last step wipes out all previous data from the container.

@bobcallaway bobcallaway dismissed their stale review November 15, 2023 15:43

tests need changed

@haydentherapper
Copy link
Contributor Author

Trillian upgraded at HEAD, db_server has not

auto-merge was automatically disabled February 8, 2024 00:38

Pull request was closed

@haydentherapper haydentherapper deleted the haydentherapper-patch-1 branch November 19, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants