Fix panic when parsing SSH SK pubkeys #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because these pubkey types do not implement ssh.CryptoPublicKey, which causes a panic when we try to do a type assertion. Also realized we weren't handling SSH certs, so now we extract the pubkey from the cert before trying to parse it. Had to reimplement parsing the SK pubkeys because there is no other way to extract the raw pubkey from it. After golang/go#62518, this will get cleaned up. Signed-off-by: Hayden Blauzvern <[email protected]>
haydentherapper
force-pushed
the
fix-ssh
branch
from
a8c9221 to
55389da
Compare
Codecov Report
@@ Coverage Diff @@
## main #1712 +/- ##
==========================================
- Coverage 66.84% 66.79% -0.06%
==========================================
Files 88 88
Lines 8850 8919 +69
==========================================
+ Hits 5916 5957 +41
- Misses 2231 2250 +19
- Partials 703 712 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bobcallaway
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because these pubkey types do not implement ssh.CryptoPublicKey, which causes a panic when we try to do a type assertion.
Also realized we weren't handling SSH certs, so now we extract the pubkey from the cert before trying to parse it.
Had to reimplement parsing the SK pubkeys because there is no other way to extract the raw pubkey from it. After golang/go#62518, this will get cleaned up.
Summary
Release Note
Documentation