chore: fix backfill-redis Makefile target
#1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes a minor change to the Makefile's `backfill-redis` target to output a binary named `backfill-redis`, fixing what was probably a simple copy/paste error when the target was introduced. Signed-off-by: Lance Ball <[email protected]>
lance
added a commit
to lance/rekor
that referenced
this pull request
Sep 15, 2023
This commit adds a Dockerfile for building a `backfill-redis` image, which should be used periodically to ensure that redis contains the complete rekor log. The patchfile is required due to this upstream issue: sigstore#1685 Once that pull request has been merged, we'll need to remove the patchfile from `main` but not from the `midstream-v1.2.2` branch unless it is backported upstream. Signed-off-by: Lance Ball <[email protected]>
lance
added a commit
to securesign/rekor
that referenced
this pull request
Sep 15, 2023
This commit adds a Dockerfile for building a `backfill-redis` image, which should be used periodically to ensure that redis contains the complete rekor log. The patchfile is required due to this upstream issue: sigstore#1685 Once that pull request has been merged, we'll need to remove the patchfile from `main` but not from the `midstream-v1.2.2` branch unless it is backported upstream. /cherry-pick midstream-v1.2.2 Signed-off-by: Lance Ball <[email protected]>
lance
added a commit
to securesign/rekor
that referenced
this pull request
Sep 15, 2023
This commit adds a Dockerfile for building a `backfill-redis` image, which should be used periodically to ensure that redis contains the complete rekor log. The patchfile is required due to this upstream issue: sigstore#1685 Once that pull request has been merged, we'll need to remove the patchfile from `main` but not from the `midstream-v1.2.2` branch unless it is backported upstream. /cherry-pick midstream-v1.2.2 Signed-off-by: Lance Ball <[email protected]>
bobcallaway
approved these changes
Sep 15, 2023
Codecov Report
@@ Coverage Diff @@
## main #1685 +/- ##
==========================================
+ Coverage 66.84% 66.88% +0.03%
==========================================
Files 88 88
Lines 8850 8850
==========================================
+ Hits 5916 5919 +3
+ Misses 2231 2229 -2
+ Partials 703 702 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
lance
pushed a commit
to securesign/rekor
that referenced
this pull request
Sep 20, 2023
Just a small pr to remove the 0002-makefile.patch as sigstore#1685 was merged meaning its not needed anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes a minor change to the Makefile's
backfill-redistarget to output a binary namedbackfill-redis, fixing what was probably a simple copy/paste error when the target was introduced.Fixes: #1684
Summary
The
backfill-redisMakefile target outputs a binary with the namerekor-serverinstead ofbackfill-redis.Release Note
NONE
Documentation
NONE